Add tests for previously untested utility functions#1124
Merged
oscarlevin merged 2 commits intomainfrom Mar 21, 2026
Merged
Conversation
…as_help_str, is_earlier_version, hash_path, xml_syntax_is_valid Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Consolidate and update testing issues
Add tests for previously untested utility functions
Mar 20, 2026
Copilot AI
added a commit
that referenced
this pull request
Mar 22, 2026
* Initial plan * Add tests for utility functions: working_directory, format_docstring_as_help_str, is_earlier_version, hash_path, xml_syntax_is_valid Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com>
Copilot AI
added a commit
that referenced
this pull request
Mar 22, 2026
- Rebased on origin/main (includes new tests and changes from #1124-#1128) - Ran `poetry run black .` for formatting (reformatted test_generate.py) - Added Fixed entry in CHANGELOG.md under [Unreleased] Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/72d5b309-fec0-4dad-8af0-1cbe035c2679
oscarlevin
added a commit
that referenced
this pull request
Mar 22, 2026
- Rebased on origin/main (includes new tests and changes from #1124-#1128) - Ran `poetry run black .` for formatting (reformatted test_generate.py) - Added Fixed entry in CHANGELOG.md under [Unreleased] Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/72d5b309-fec0-4dad-8af0-1cbe035c2679
oscarlevin
added a commit
that referenced
this pull request
Mar 22, 2026
…e updates (#1130) * Initial plan * Add error handling for failed image generation and tests to verify behavior - In generate.py, each individual_* function now logs an error and raises an Exception when core does not produce the expected output file. This ensures the failure propagates up through generate_assets() so the asset type is not added to the successful_assets list and the cache is not incorrectly updated. - Add tests/test_generate.py with 8 tests covering all four individual_* functions, verifying both the failure case (raises) and success case (no raise). Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/7b12f474-b534-45aa-813c-9a2f75f4d8c3 * Initial plan * Rebase on main, run black formatting, add CHANGELOG entry - Rebased on origin/main (includes new tests and changes from #1124-#1128) - Ran `poetry run black .` for formatting (reformatted test_generate.py) - Added Fixed entry in CHANGELOG.md under [Unreleased] Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/72d5b309-fec0-4dad-8af0-1cbe035c2679 * drop failed assets from cache --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Co-authored-by: Oscar Levin <oscar.levin@unco.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several utility functions in
pretext/utils.pylacked test coverage, andtest_working_directoryhad an unresolved# TODOcomment.Changes
test_working_directory: Completed the TODO — asserts the working directory is restored after the context manager exitstest_format_docstring_as_help_str: Covers paragraph collapsing, double-newline preservation, whitespace stripping, and empty inputtest_is_earlier_version: Covers major/minor/patch comparisons, equality, and the post-release dev build convention (e.g.2.11.5 < 2.11.5.dev0)test_hash_path: Asserts 10-char hex output, determinism, and uniqueness across distinct pathstest_xml_syntax_is_valid: Covers well-formed PreTeXt, wrong root tag, malformed XML, andIOErroron missing fileWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
runestone.academy/usr/bin/python python scripts/fetch_core.py(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.