Refactor payout distribution logic to require explicit claims from winners#291
Merged
greatest0fallt1me merged 1 commit intoPredictify-org:masterfrom Jan 31, 2026
Merged
Conversation
…nners - Updated comments to clarify that winners must call `claim_winnings(user, market_id)` to receive payouts after market resolution. - Removed automatic payout distribution from the resolution process to prevent segfaults and ensure clarity in the claiming process. - Adjusted tests to reflect the new requirement for winners to explicitly claim their winnings, ensuring accurate state verification.
Contributor
Author
|
@greatest0fallt1me Please review this PR. thanks. |
Contributor
Author
|
Please provide me with compliments for this Pr. I have worked on other issues as well in Predictify. Please check and provide compliments, @greatest0fallt1me |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
claim_winnings(user, market_id)to receive payouts after market resolution.Closes #249