Fix things #14
Merged
Fix things #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--gpu` is not a valid `nvidia-docker` flag
…ablePackage.override` and `ml-ops.overridablePackage.overrideAttrs`
…d in config.pythonPackage when using poetry2nix
fmmoret
reviewed
Nov 16, 2023
| }); | ||
| }) | ||
| ml-ops.common.pythonPackage = { | ||
| pipe = [ |
There was a problem hiding this comment.
what change are you making here? Are pipe and override attributes intrinsic to all nix objects? or are they just names you're using
There was a problem hiding this comment.
nvm. I see that they are just constructs that you've made and are manually handling / passing to pipe etc. etc.
There was a problem hiding this comment.
lib.trivial.pipe is a nixpkgs function, and ml-ops.common.pythonPackage.pipe is an option of the arguments passed to lib.trivial.pipe. The pipe option introduced by this PR is more general than previous override and overrideAttrs options.
There was a problem hiding this comment.
fmmoret
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a lot of issues preventing us from submitting a job to AKS:
libnvidia-containercompatibility issue by cherry-picking fix: letdevenv-created OCI images be compatible withlibnvidia-containercachix/devenv#873pkgspassed topoetry2nix, so that dependents of Python also get rebuilt agained the customized python. Without the changes dependent packages of Python will conflicts with the customized python.maxLayersoption to build multi-layer images by cherry-picking feat: addcontainers.<name>.maxLayersoption cachix/devenv#872