Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old typer extra and update json -> model_dump_json (LC 0.3+ support) #312

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Sep 17, 2024

let me know if we need some of this old pydantic syntax around for v1 backport compat or something! it was just causing me errors when installing the newest controlflow

former is causing a warning

» uv pip install -e .
Resolved 113 packages in 1.15s
   Built controlflow @ file:///Users/nate/github.com/jlowin/controlflow
Prepared 1 package in 853ms
Uninstalled 1 package in 0.66ms
Installed 1 package in 1ms
 ~ controlflow==0.9.4.dev2+ga234180 (from file:///Users/nate/github.com/jlowin/controlflow)
warning: The package `typer==0.12.5` does not have an extra named `all`

latter is causing an error (like this) on newest pydantic

TypeError: `dumps_kwargs` keyword arguments are no longer supported.

also fixes a couple tests and updates some to avoid warnings like pytest trying to collect TestHandler or extra marks

@github-actions github-actions bot added the tests Adds or improves unit tests label Sep 17, 2024
@jlowin
Copy link
Member

jlowin commented Sep 18, 2024

Thanks @zzstoatzz! Combined with changing the pin (which I committed here) this should close #319. I think there's more work to do to "fully" support it but at least it's no longer breaking.

@jlowin jlowin added the enhancement Enhance an existing feature label Sep 18, 2024
@jlowin jlowin changed the title remove old typer extra and update json -> model_dump_json remove old typer extra and update json -> model_dump_json (LC 0.3+ support) Sep 18, 2024
@jlowin jlowin merged commit 623e485 into main Sep 18, 2024
4 checks passed
@jlowin jlowin deleted the small-updates branch September 18, 2024 16:50
@jlowin jlowin mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance an existing feature tests Adds or improves unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants