add slackbot example and update typing + debug logs #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowin
reviewed
Oct 25, 2024
src/controlflow/agents/agent.py
Outdated
| @@ -289,7 +289,9 @@ def _run_model( | |||
| tools = as_tools(self.get_tools() + tools) | |||
| model = self.get_model(tools=tools) | |||
|
|
|||
| logger.debug(f"Running model {model} for agent {self.name} with tools {tools}") | |||
| logger.debug( | |||
| f"Running model {controlflow.settings.llm_model} for agent {self.name} with tools {[t.name for t in tools]!r}" | |||
There was a problem hiding this comment.
I think this is actually not correct for the model -- this will log the global setting, not the agent's own setting (if it was overridden)
zzstoatzz
force-pushed
the
slackbot
branch
2 times, most recently
from
1763e98 to
41954d2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an initial FastAPI slackbot example and updates some typing on the
Flowclass so that its clear to users in their IDE what thingsFlowacceptsalso fixes the async case with
as_task(test_task_decorator_async_as_taskwas throwing an "unawaited cororoutine" error)relatedly in PrefectHQ/prefect#15792, we noticed that
default=is required inFielddefinitions for the type checker to recognize defaults as "not required" by the constructor of a model likeFlowi plan to add to this slackbot over time