Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(orchestrator): OrchestratorError to serialize Exception as str #373

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix(orchestrator): OrchestratorError to serialize Exception as str #373

merged 2 commits into from
Nov 5, 2024

Conversation

teocns
Copy link
Contributor

@teocns teocns commented Nov 2, 2024 •
edited
Loading

Issue occurs when attempting to model_dump_json() or json() with OrchestratorError.error is Exception

PydanticSerializationError: Unable to serialize unknown type: <class 'TypeError'>

@teocns
Copy link
Contributor Author

teocns commented Nov 4, 2024

Extra commit slipped in.... like it's Christmas

@jlowin
Copy link
Member

jlowin commented Nov 5, 2024

Thank you!

@jlowin jlowin merged commit 33a40cd into PrefectHQ:main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowin jlowin jlowin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teocns @jlowin