-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy example and fix typing #382
Open
zzstoatzz
wants to merge
8
commits into
main
Choose a base branch
from
example-deploy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b5bc9dd
deploy example and fix typing
zzstoatzz be41a7c
update example
zzstoatzz 041efb0
clarify
zzstoatzz 6e5a43d
add docker example
zzstoatzz 85fa4fd
make 3.9 happy
zzstoatzz 329cf8e
make friendly to any user
zzstoatzz ce25892
spiffy
zzstoatzz ca314f8
Merge branch 'main' into example-deploy
zzstoatzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import sys | ||
from pathlib import Path | ||
|
||
import controlflow as cf | ||
|
||
|
||
@cf.task() | ||
def write_poem(topic: str) -> str: | ||
"""Write four lines that rhyme""" | ||
return f"The topic is {topic}" | ||
|
||
|
||
@cf.flow() | ||
def write_poems(topics: list[str]) -> list[str]: | ||
return write_poem.map(topics).result() | ||
|
||
|
||
if __name__ == "__main__": | ||
if len(sys.argv) > 1 and sys.argv[1] == "serve": | ||
write_poems.serve() | ||
elif len(sys.argv) > 1 and sys.argv[1] == "deploy": | ||
write_poems.from_source( | ||
source=str((p := Path(__file__)).parent.resolve()), | ||
entrypoint=f"{p.name}:something", | ||
).deploy(name="some-deployment", work_pool_name="local-process-pool") | ||
else: | ||
write_poems(["roses", "violets", "sugar", "spice"]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'something' here should probably be 'write_poems'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, an example that deploys it by pulling an image, would solve all of my problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch @alkiviadis-savvopoulos!
fixed that and also added a docker example