Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 4.4.0 #176

Merged
merged 12 commits into from
Jan 10, 2024
Merged

Release version 4.4.0 #176

merged 12 commits into from
Jan 10, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Jan 9, 2024

Questions Answers
Description? Release version 4.4.0
Type?
BC breaks?
Deprecations?
Fixed ticket?
How to test?

@Hlavtox Hlavtox added this to the 4.4.0 milestone Jan 9, 2024
Add controller for CRON tasks and minor fixes
@Hlavtox Hlavtox marked this pull request as ready for review January 10, 2024 13:57
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

I can't generate multiple sitemap with brands.

Tested #173 :
On the first try it works well. My sitemap with my brands is well displayed.
Then I add another brand.
I try to generate another sitemap.
No brands are displayed on the sitemap.

Screen.Recording.2024-01-10.at.17.43.12.mov

Only the products are displayed :/

Also, with gsitemap v4.3.0, we had a lot more elements :
Screenshot 2024-01-10 at 17 51 31

Whereas with v4.4.0, we only have a few :
Screenshot 2024-01-10 at 17 53 06

Could you check ? ^^
Thanks!

@florine2623 florine2623 removed their assignment Jan 10, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jan 10, 2024

@florine2623

No brands are displayed on the sitemap.

Because you disabled the manufacturer controller in the module configuration. It will not list the brands in the sitemap if you do it.

Whereas with v4.4.0, we only have a few :

That's expected behavior because of this PR - #164. These pages are blocked by robots.txt in the core, so it doesn't make sense to list them in the XML sitemap.

@florine2623
Copy link
Contributor

Ok, noted !

Tested again, indeed I forgot to enable that 😅
Screenshot 2024-01-10 at 18 06 20

Works like a charm :
Screenshot 2024-01-10 at 18 06 04
Screenshot 2024-01-10 at 18 06 09

It is QA ✅

@florine2623 florine2623 self-assigned this Jan 10, 2024
@Hlavtox Hlavtox merged commit 2f9f69f into master Jan 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants