Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove caption and title tags of the images #179

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

Uhor
Copy link
Contributor

@Uhor Uhor commented Jan 19, 2024

Questions Answers
Description? Google has stopped using the tags <image:caption>, <image:geo_location>, <image:title>, <image:license>, so we can delete that part from the code, making sitemap file lighter (good for big stores).
Type? improvement
BC breaks? no
Deprecations? yes
Fixed ticket? -
How to test? Just generate a new sitemap

Links:

Hlavtox
Hlavtox previously approved these changes Jan 19, 2024
@Hlavtox Hlavtox added this to the 4.4.1 milestone Jan 19, 2024
@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 19, 2024

@Uhor You need to remove one error from 1.7.8 phpstan config, then all good :-)

 Ignored error pattern #Parameter \#1 \$str of function strip_tags expects  
 string, array<string> given.# was not matched in reported errors.    

@Uhor
Copy link
Contributor Author

Uhor commented Jan 23, 2024

Should I change the version?

@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 23, 2024

@Uhor Not needed, we can bump it later

Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Uhor ,

Generated multiple sitemaps with different languages.
The tags <image:caption>, <image:geo_location>, <image:title> and <image:license> are not displayed anymore and I found no other issue.

LGTM ✅

@Hlavtox Hlavtox merged commit 4507655 into PrestaShop:dev Feb 8, 2024
13 checks passed
@Hlavtox
Copy link
Contributor

Hlavtox commented Feb 8, 2024

Good job everyone!

@Uhor Adrian, you can bump the version to 4.5.0 and we can do a release. ;-)

@Uhor
Copy link
Contributor Author

Uhor commented Feb 8, 2024

Good job everyone!

@Uhor Adrian, you can bump the version to 4.5.0 and we can do a release. ;-)

It's already merged and didn't bump the version. It's okay?

@Hlavtox
Copy link
Contributor

Hlavtox commented Feb 8, 2024

Yes, PRs to develop branch don't have to bump a version, if they are not adding some upgrade scripts. You can do it in a separate PR. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants