gRPC 2.2.4 #41
gRPC 2.2.4 #41
Conversation
some of these changes seem like they need database changes as well, that needs to be talked about
The interval specifies the period that the console waits before executing a task (downloading BOSS data in this case). This is an optional parameter on the Wii U tasksheet, I assume for overriding the default value that a game sets
I don't know about the details about |
|
About the CTR containers, I think it might be best to make two separate file schemas depending on the platform It's also important to consider all of the technicalities of the 3DS side, since for some operations we need to access some fields from the container itself (such as the payload size for NPFL, and the exposed fields on the gRPC). For this we can consider duplicating this container metadata on the schema for easier access |
|
@DaniElectra The gRPC server is now upgraded to BOSSv2. I've tested that everything compiles, but have not tested them on an actual console (since some of the changes did affect the console endpoints) |
|
Copying this over from Discord for clarity:
Would you like me to just redo the Wii U schema as well and we can just nuke/reseed the old files? Or keep on doing this conversation? Either is fine with me |
Also use proper size on content size column.
I think redoing the schema would be best, while we're there we can also solve this TODO: data_id: Number, // TODO - Wait until https://github.com/typegoose/auto-increment/pull/21 is merged and then change this to BigIntBefore you do that I'm working on some changes and bugfixes in this branch. I'm looking on importing all the known apps from the archival-tools repo to the known apps gRPC. There are some apps whose title ID is unknown though. Would it be fine to import those aswell with title ID set to 0? |
|
I think a title ID of 0 should be fine yeah, sounds good |
This allows us to create files targeted to specific countries and/or languages without any issues such as returning a random language when none is specified.
Use the JSON list of apps documented on the archival-tools repo as source for these apps. The title IDs were obtained by querying tasksheets of these apps, but not all of them were available so the title ID is set to 0 in those cases. The title name and region were populated though various public sources, but they aren't perfect so some names and/or regions are left unknown.
When using this mode, the server only returns the filename, type, size and attributes of a file.
|
I have done my changes, in theory everything should work (it compiles) but haven't tested it. You can remake the schema now |
|
@DaniElectra I've updated the model now, I think that's all that was requested? Also untested, but it compiles and looks correct |
Also add attributes support for Wii U.
Plus some other fixes.
Having a task file with no payload contents is perfectly valid and supported officially. This can be used for files where only the metadata is relevant, such as on Team Kirby Clash Deluxe passwords which are stored on a file description and the prize comes from the attributes.
Resolves #XXX
Changes:
Updates the gRPC server to match release 2.2.4. Marked as draft because not everything is implemented, and some stuff is stubbed. There also seems to be changes which require updates to the database/schemas, that needs to be talked about. CC @DaniElectra
Namely:
What is
interval?Is
autoDeletesupposed to use the built-in Mongo auto deletion? And if so, is it fine that we will be mixing soft deletes with hard deletes?These changes introduce CTR containers. We don't have a schema for this yet, so we need to discuss how we handle that. Because of the lack of schema, the 3DS side of things is not implemented atm
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.