Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate black box #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Migrate black box #6

wants to merge 3 commits into from

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Dec 27, 2024

Original PR: bevyengine#16980

This is a test to see how Codspeed reacts to benchmarking pull requests.

Originally attempted in #5, but CI was broken so I'm opening this to force it to run.

…tead

`core::hint::black_box()` has no performance overhead, and is the preferred method of blocking optimizations in benchmarks. It was likely introduced after our benchmarks were created, which is why we didn't use it before.
Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #6 will degrade performances by 22.84%

Comparing BD103:migrate-black-box (49feae5) with main (bfc1fff)

Summary

⚡ 11 improvements
❌ 11 (👁 11) regressions
✅ 625 untouched benchmarks

Benchmarks breakdown

Benchmark main BD103:migrate-black-box Change
Table 621.6 µs 552.2 µs +12.58%
Table 63.1 µs 56.1 µs +12.38%
Table 621.6 µs 552.1 µs +12.59%
Table 63.1 µs 56.1 µs +12.5%
👁 500_schedule_noconstraints 39 ms 46.4 ms -15.96%
👁 MultiThreaded 741.9 ns 829.4 ns -10.55%
👁 SingleThreaded 1.2 µs 1.3 µs -11.2%
001_systems 27.2 µs 23.7 µs +14.67%
👁 0_entities 798.3 ns 915 ns -12.75%
entity_set_build[100] 5.9 µs 5.2 µs +13.49%
50000_entities_table 174.5 µs 153.5 µs +13.65%
50000_entities_table 181.4 µs 139.7 µs +29.85%
cubic_position_Vec3A 89.2 ns 60.3 ns +47.93%
trait_object 182.2 ns 153.1 ns +19.06%
Generic[32] 616.1 ns 557.8 ns +10.46%
👁 many_maps_iter 150.1 ms 194.6 ms -22.84%
👁 threads[16] 150.2 ms 194.7 ms -22.83%
👁 threads[1] 150.2 ms 194.7 ms -22.83%
👁 threads[2] 150.2 ms 194.7 ms -22.84%
👁 threads[32] 150.2 ms 194.7 ms -22.83%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant