Feat call maybe reinit diloco #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackmin801
approved these changes
Oct 4, 2024
Comment on lines
+273
to
+277
|
|
||
| if self.world_info.global_world_size == 1: | ||
| # no op if we only have one node | ||
| return | ||
|
|
There was a problem hiding this comment.
There's an edge case that we probably dont care about rn. Which is what if the starting number of nodes is 1? I think atm its fine to not cover this case
There was a problem hiding this comment.
Ah yes very good point. Nice to keep in mind ideed
samsja
pushed a commit
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebookresearch/optimizers#37 Reviewed By: anana10c Differential Revision: D65546537 Pulled By: tsunghsienlee fbshipit-source-id: 0eaf18d0c732101d5634c693e45fd5511e349fa5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.