Feat wget ckpt #40
Merged
Feat wget ckpt #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsja
force-pushed
the
feat-wget-ckpt
branch
2 times, most recently
from
c71844e to
3b94a44
Compare
JohannesHa
reviewed
Oct 6, 2024
Jackmin801
reviewed
Oct 7, 2024
Jackmin801
reviewed
Oct 7, 2024
src/zeroband/train.py
Outdated
Comment on lines
223
to
224
| if config.ckpt.resume is not None: | ||
| # all is inplace | ||
| ckpt_manager.load(resume_ckpt_path=config.resume) | ||
| ckpt_manager.load(resume_ckpt_path=config.ckpt.resume) | ||
|
|
||
| model.train() | ||
| if elastic_device_mesh.live_recovery.need_live_recovery: | ||
| ckpt_manager.download_and_load_ckpt_from_peers( | ||
| elastic_device_mesh.live_recovery.get_adress(world_info.global_rank - 1) | ||
| ) | ||
| elastic_device_mesh.live_recovery.need_live_recovery = False | ||
| diloco.fake_step(model) |
There was a problem hiding this comment.
Do you need the load from resume_ckpt_path if you are doing live recovery? does it skip all the state live recovered state dict inits and only does dataloader loading?
add env var port live reco
|
working fine now |
samsja
pushed a commit
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebookresearch/optimizers#40 Reviewed By: gajjanag Differential Revision: D65608921 Pulled By: tsunghsienlee fbshipit-source-id: ea688009da97e9739a1146de83754384efe8a52c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
live reco workig