Skip to content

tunnel retries on connection loss + better cleanup#459

Open
kcoopermiller wants to merge 3 commits intomainfrom
feature/tunnel-login-retry
Open

tunnel retries on connection loss + better cleanup#459
kcoopermiller wants to merge 3 commits intomainfrom
feature/tunnel-login-retry

Conversation

@kcoopermiller
Copy link
Copy Markdown
Member

@kcoopermiller kcoopermiller commented Mar 20, 2026

Note

Medium Risk
Moderate risk because it changes tunnel lifecycle/cleanup behavior via atexit hooks and alters frpc reconnection behavior, which could impact process teardown or long-running tunnel stability.

Overview
Improves tunnel robustness by configuring frpc to keep retrying after losing the server connection (loginFailExit = false) instead of exiting.

Adds an atexit hook to automatically call Tunnel.sync_stop() after a successful start, and ensures the hook is unregistered on both async stop() and sync_stop() to avoid double-cleanup or lingering handlers.

Written by Cursor Bugbot for commit 77b03b4. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75f996152d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant