fix(rl): whitespace-only API logs show placeholder, not blank#477
Draft
willccbb wants to merge 1 commit intocursor/prime-rl-logs-timeout-2d2efrom
Draft
fix(rl): whitespace-only API logs show placeholder, not blank#477willccbb wants to merge 1 commit intocursor/prime-rl-logs-timeout-2d2efrom
willccbb wants to merge 1 commit intocursor/prime-rl-logs-timeout-2d2efrom
Conversation
Poll up to 30s for non-whitespace log content before displaying, and use raw_logs.strip() for the raw-mode print check so API responses that are only whitespace show the same message as truly empty logs. Co-authored-by: will brown <willccbb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
prime rl logsruns without--follow, the API can return a response that is only whitespace. Previously, raw mode (--raw) treated that string as truthy and printed it, so users saw a blank screen instead of the yellow "No logs available yet." message.Changes
raw_logs.strip()for the raw-mode display branch so whitespace-only responses are handled like empty logs.Formatted mode was already correct because
clean_logsstrips empty lines; the mismatch was between polling semantics and raw display.