fix data splitting #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsja
force-pushed
the
fix-data-splitting
branch
from
6c0c85c to
9ca847d
Compare
Jackmin801
reviewed
Oct 8, 2024
Comment on lines
+118
to
+119
| world_size=world_info.world_size * world_info.global_world_size, | ||
| rank=world_info.rank + world_info.global_rank * world_info.global_world_size, |
There was a problem hiding this comment.
Not really a bug. You now need to set data.data_rank and data.data_world_size in order for the splitting between diloco workers. My bad for not putting it in the README :(
samsja
pushed a commit
that referenced
this pull request
Jan 10, 2025
Summary: Follow-up fix to facebookresearch/optimizers#57. Pull Request resolved: facebookresearch/optimizers#59 Reviewed By: gajjanag Differential Revision: D66828698 Pulled By: tsunghsienlee fbshipit-source-id: bca4c322403ddfbe8cb45c35cd076b5d567b4b35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.