use step ckpt folder #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsja
pushed a commit
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebookresearch/optimizers#73 It was discovered that internal and external Ruff formater formats differently on codes with multiple context managers and this will convert the `assertRaises*` usages into non-context manager fashion. [This was caused some OSS CI complains before](facebookresearch/optimizers#65), and this diff should reduce the chance of discrepency between diff Ruff formater setting on multiple context managers. Reviewed By: chuanhaozhuge Differential Revision: D67681063 fbshipit-source-id: a4a26818c3345f78b6b77e6b336fd3639c1ab83d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.