Conversation
| except ( | ||
| KeyError | ||
| ) as e: # download_model catches all exceptions and re-raises as KeyError |
There was a problem hiding this comment.
If this odd formatting was introduced solely for the in-line comment, it would be better to move it within the except block
There was a problem hiding this comment.
If this changed was introduced by the ruff pre-commit hook, this is a reminder that you should look at all changes proposed by pre-commit hooks.
There was a problem hiding this comment.
Assuming this was caused by ruff, given that this line was otherwise not changed, how did this by pass both the pre-commit hooks and GitHub Actions?
There was a problem hiding this comment.
Assuming this was caused by ruff, given that this line was otherwise not changed, how did this by pass both the pre-commit hooks and GitHub Actions?
I was wondering that too. This change was indeed caused by ruff (uv run ruff format). Without modifying it, the CI of this PR failed. But how did it pass in the first place...
There was a problem hiding this comment.
Did you have the pre-commit hooks set up locally? It sounds like it didn't run on that commit somehow.
2 participants
small fix: change cometkiti return type from list to a single value