Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Refinement Handling in Verilog Verification Target Generation #219

Open
wants to merge 81 commits into
base: master
Choose a base branch
from

Conversation

zhanghongce
Copy link
Member

@zhanghongce zhanghongce commented Sep 16, 2021

Work in progress, do not merge at this point!
This pull request is to see if the test coverage is sufficient.

@zhanghongce zhanghongce self-assigned this Oct 28, 2021
@zhanghongce
Copy link
Member Author

zhanghongce commented Oct 28, 2021

Honestly speaking, I'm having issues with compiling it on Windows. The core issue is in the dependent repo: https://github.com/zhanghongce/vexpparser, where I have no way to have the compiler on windows find the header FlexLexer.h in winflexbison3 package.

 Directory of C:\ProgramData\chocolatey\lib\winflexbison3\tools

10/24/2021  12:12 AM    <DIR>          .
10/24/2021  12:12 AM    <DIR>          ..
01/05/2021  09:58 PM             5,816 changelog.md
10/24/2021  12:11 AM               392 chocolateyInstall.ps1
10/24/2021  12:12 AM    <DIR>          custom_build_rules
10/24/2021  12:12 AM    <DIR>          data
05/22/2020  12:55 AM             7,113 FlexLexer.h
05/22/2020  12:55 AM               400 UNISTD_ERROR.readme
01/05/2021  09:59 PM           665,600 win_bison.exe
01/05/2021  09:59 PM           569,344 win_flex.exe
               6 File(s)      1,248,665 bytes
               4 Dir(s)  94,412,075,008 bytes free

I tried adding an option like cmake .. -DCMAKE_CXX_FLAGS=/I\ %ProgramData%\\chocolatey\\lib\\winflexbison3\\tools to the instruct the compiler but it does not work. If anyone knows the solution, please help here.

@Bo-Yuan-Huang
Copy link
Collaborator

Honestly speaking, I'm having issues with compiling it on Windows. The core issue is in the dependent repo: https://github.com/zhanghongce/vexpparser, where I have no way to have the compiler on windows find the header FlexLexer.h in winflexbison3 package.

Or perhaps terminate the Windows support.

  • The new maintaining team doesn't seem to have enough bandwidth to keep the original CI working.
  • Windows-based ILAng users are rare.

@ILAng-service
Copy link
Collaborator

Honestly speaking, I'm having issues with compiling it on Windows. The core issue is in the dependent repo: https://github.com/zhanghongce/vexpparser, where I have no way to have the compiler on windows find the header FlexLexer.h in winflexbison3 package.

Or perhaps terminate the Windows support.

  • The new maintaining team doesn't seem to have enough bandwidth to keep the original CI working.
  • Windows-based ILAng users are rare.

Hi Hongce,

I will take a look at this. As we have already terminated several other CIs (e.g. travis-related ones due to the university account's credit issue), I would try my best to keep the rest CIs on.
But if this PR is in a hurry (for DAC tutorial), I can temporarily stop the windows build to get it merged. Feel free to give me a deadline for this.

@yuex1994
Copy link
Contributor

Honestly speaking, I'm having issues with compiling it on Windows. The core issue is in the dependent repo: https://github.com/zhanghongce/vexpparser, where I have no way to have the compiler on windows find the header FlexLexer.h in winflexbison3 package.

 Directory of C:\ProgramData\chocolatey\lib\winflexbison3\tools

10/24/2021  12:12 AM    <DIR>          .
10/24/2021  12:12 AM    <DIR>          ..
01/05/2021  09:58 PM             5,816 changelog.md
10/24/2021  12:11 AM               392 chocolateyInstall.ps1
10/24/2021  12:12 AM    <DIR>          custom_build_rules
10/24/2021  12:12 AM    <DIR>          data
05/22/2020  12:55 AM             7,113 FlexLexer.h
05/22/2020  12:55 AM               400 UNISTD_ERROR.readme
01/05/2021  09:59 PM           665,600 win_bison.exe
01/05/2021  09:59 PM           569,344 win_flex.exe
               6 File(s)      1,248,665 bytes
               4 Dir(s)  94,412,075,008 bytes free

I tried adding an option like cmake .. -DCMAKE_CXX_FLAGS=/I\ %ProgramData%\\chocolatey\\lib\\winflexbison3\\tools to the instruct the compiler but it does not work. If anyone knows the solution, please help here.

Hi Hongce,

Can you grant me access to the repo for pr, I'd like to make a few changes to the script to see if that works.

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2021

This pull request introduces 1 alert when merging fb1c9d9 into 14b66e6 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

@zhanghongce
Copy link
Member Author

zhanghongce commented Nov 4, 2021

Hi Hongce,

Can you grant me access to the repo for pr, I'd like to make a few changes to the script to see if that works.

Hi Yue,

I thought the access to this pr was always there.

Screenshot from 2021-11-04 12-54-37

Nevertheless, I also add you to the repo and this is under branch refinement-upgrade.

@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2021

This pull request introduces 1 alert when merging 4924f92 into 14b66e6 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants