Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python13 #240

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Support python13 #240

wants to merge 5 commits into from

Conversation

LeoGrin
Copy link
Collaborator

@LeoGrin LeoGrin commented Mar 12, 2025

Fix #234

Copy link
Collaborator

@noahho noahho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Just take a look at the requirements spec

@@ -14,7 +14,7 @@ dependencies = [
"einops>=0.2.0,<0.9",
"huggingface-hub>=0.0.1,<1",
]
requires-python = ">=3.9,<3.13"
requires-python = ">=3.9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be <= 3.13 as we aren't testing newer versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See some discussion in #234, I changed my mind and now think it makes sense not to upper bound the python version. WDYT?

@noahho noahho requested review from noahho and Copilot March 12, 2025 16:40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Python 3.13 by updating workflow configurations, modifying package metadata, adjusting tests, and updating the README badge and compatibility statement.

  • Updated GitHub Actions workflows to use Python 3.13 and conditionally install onnx.
  • Modified pyproject.toml to remove the upper bound on supported Python versions and added Python 3.13 to classifiers.
  • Updated tests and README to reflect Python 3.13 support.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/pull_request.yml Update of python-version and conditional installation for onnx.
pyproject.toml Adjustment of requires-python constraint and classifiers update.
tests/test_classifier_interface.py Added xfail for onnx export tests on python3.13.
tests/test_regressor_interface.py Added xfail for onnx export tests on python3.13.
README.md Updated badge and compatibility list to include Python 3.13.
Comments suppressed due to low confidence (2)

.github/workflows/pull_request.yml:82

  • Ensure that the comparison against '3.13' correctly handles potential variations in how the Python version might be represented (e.g., '3.13.0'); consider normalizing the version string before comparison.
if [[ "${{ matrix.python-version }}" != "3.13" ]]; then

pyproject.toml:17

  • By removing the upper bound on the Python version, the package may be installed on versions that are not fully supported (e.g., potential issues with onnx on Python 3.13). Consider documenting this behavior clearly in the release notes or adjusting the requirement if appropriate.
requires-python = ">=3.9"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip defaults to older tabpfn version when you have python3.13.
2 participants