Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made home text and logo redirect to home section #297

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

Abankita
Copy link
Contributor

@Abankita Abankita commented Oct 8, 2024

Related Issue

None

Fixes #281

Description

This pull request fixes the issue where clicking the logo and the "Home" link in the navigation bar did not redirect to the home section. The href attributes of both the logo and the "Home" link have been updated to include #home, and the home section has been assigned the corresponding id="home". This ensures that both elements now properly navigate to the home section on the page.
Linking the logo and "Home" link to the home section improves navigation by providing users with an intuitive way to return to the top of the page. It enhances user experience and follows established web design conventions for consistent, predictable navigation.

Fixes #281

Type of PR

  • Feature enhancement

Screenshots / videos (if applicable)

(https://drive.google.com/file/d/10bxWOstdqp-WJw8XKcSFx11ugiLgMGvZ/view?usp=drivesdk)

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 2:36pm

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit a6f113d
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6705436ad3a1d30008e58b29
😎 Deploy Preview https://deploy-preview-297--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Abankita Abankita changed the title Made home text and logo redirect to home page Made home text and logo redirect to home section Oct 8, 2024
@Abankita
Copy link
Contributor Author

Abankita commented Oct 8, 2024

@PriyaGhosal I have attached the google drive link to the video of the changes I made. Please review my PR. Any suggestions or feedback is welcomed.

@PriyaGhosal PriyaGhosal merged commit e14206c into PriyaGhosal:main Oct 9, 2024
5 checks passed
@PriyaGhosal
Copy link
Owner

@Abankita
Uploading image.png…
Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to home page on clicking logo
2 participants