Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#225 add link highlighting #316

Closed
wants to merge 1 commit into from

Conversation

Nimrat0199
Copy link

Fixes: #225

Description

Implemented Intersection Observer to detect which section is currently visible in the viewport.
Automatically applies an "active" class to the corresponding navbar link when a section is in view, allowing the user to see which part of the page they are on.

Type of PR

  • Feature enhancement

Screenshots / videos (if applicable)

Screenshot 2024-10-08 222100
Screenshot 2024-10-08 222111
Screenshot 2024-10-08 222131
Screenshot 2024-10-08 222145
Screenshot 2024-10-08 222157
Screenshot 2024-10-08 222207

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Nimrat0199
Copy link
Author

Could you please give level2 or level3 for this as it required some coding

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 6ee3573
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/670564347bca2f0008f53acd
😎 Deploy Preview https://deploy-preview-316--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 4:58pm

@PriyaGhosal
Copy link
Owner

image
@Nimrat0199 Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

@PriyaGhosal PriyaGhosal closed this Oct 9, 2024
@Nimrat0199 Nimrat0199 deleted the feature/link branch October 9, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add link highlighting
2 participants