Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG:Login and Signup pages are not that much looking good and needs ui enhancements. #196 #397

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

tarunkumar2005
Copy link
Contributor

Related Issue

Fixes: #196

Description

So the pages of the signup and login are now merged into one with a very intrective interface and proper design. I have enhanced the user friendliness and proper ui/ux of the page appart from the js. i have added the before and after screenshots for better view on this issue i have fixed. Also i have made it responsive and professional looking.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before :-

image

image

After :-

image

image

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal Please review this quickly otherwise if you merge other PRs then it will have conflicts. Assign this to me and put relevent labels like gssoc 2024 ext and hacktoberfest and put level too.

I am removing some files okay so it will always show conflict if you merge any other PR before mine i am reducing the code and files for managing properly so review this first then check others. Its a request @PriyaGhosal

Now it is completly fixed so sorry for that small issue you are using html right so that's why there is no router like in react so static files links i need to change to make them work everything is fine now. Please review once again and don't close the PRs i can fix and then make changes in that only. @PriyaGhosal

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 83d814a
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/670683cbfd44610008755930
😎 Deploy Preview https://deploy-preview-397--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal PriyaGhosal merged commit c6af31f into PriyaGhosal:main Oct 9, 2024
5 checks passed
Copy link

vercel bot commented Oct 9, 2024

Deployment failed with the following error:

Resource is limited - try again in 22 minutes (more than 100, code: "api-deployments-free-per-day").

@PriyaGhosal
Copy link
Owner

@tarunkumar2005 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution to GSSOC'24 EXTENDED! 🎉

@rajdeepchakraborty-rc
Copy link
Contributor

@PriyaGhosal Please check issue #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:Login and Signup pages are not that much looking good and needs ui enhancements.
3 participants