Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework symbol table #27

Merged
merged 16 commits into from
Mar 25, 2024
Merged

Rework symbol table #27

merged 16 commits into from
Mar 25, 2024

Conversation

famoser
Copy link
Member

@famoser famoser commented Mar 24, 2024

The current symbol table does not collect all symbols. Notably, new declarations are not supported everywhere. Further, the symbol table treats lib statements as global context (hence not one-after-the-other, but all on the same level). This causes some invalid navigations (e.g. navigating to quantifier of different clause). Lastly, the behavior of macros is not clearly defined, and should be thought through.

This PR approaches this in the following way:

  • Implement statements which define a variable directly (rather than in their parent rule)
  • Correctly track scope of the lib (and any other statement)
  • Define and implement clear macro behaviour

@famoser famoser changed the title Support new declaration Rework symbol table Mar 25, 2024
@famoser famoser merged commit 8bab662 into main Mar 25, 2024
2 checks passed
@famoser famoser deleted the support-new-declaration branch March 25, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant