Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8 #62

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Upgrade to .NET 8 #62

merged 4 commits into from
Jan 2, 2024

Conversation

mocsharp
Copy link
Contributor

@mocsharp mocsharp commented Dec 20, 2023

Description

Upgrade to .NET 8.0 LTS.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added this to the 2.0.0 milestone Dec 20, 2023
@mocsharp mocsharp requested a review from neildsouth December 20, 2023 01:08
@mocsharp mocsharp self-assigned this Dec 20, 2023
@mocsharp mocsharp added dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Dec 20, 2023
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (758ccea) 97.47191% compared to head (e154710) 97.47191%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop         #62   +/-   ##
=============================================
  Coverage   97.47191%   97.47191%           
=============================================
  Files             12          12           
  Lines            356         356           
  Branches          37          37           
=============================================
  Hits             347         347           
  Misses             7           7           
  Partials           2           2           
Flag Coverage Δ
unittests 97.47191% <100.00000%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ication/Middleware/BasicAuthorizationMiddleware.cs 96.42857% <100.00000%> (ø)
...tication/Middleware/BypassAuthenticationHandler.cs 100.00000% <100.00000%> (ø)
...tication/Tests/BasicAuthorizationMiddlewareTest.cs 92.10526% <100.00000%> (ø)
...ation/Tests/EndpointAuthorizationMiddlewareTest.cs 100.00000% <100.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758ccea...e154710. Read the comment docs.

@mocsharp mocsharp merged commit 21ec97b into develop Jan 2, 2024
11 of 12 checks passed
@mocsharp mocsharp deleted the vchang/net8 branch January 2, 2024 18:02
@mocsharp mocsharp added build enhancement New feature or request and removed build labels Jan 2, 2024
Copy link

github-actions bot commented Jan 5, 2024

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants