Merge pull request #112 from Project-MONAI/nds-health-check-fix

Nds health check fix
Project-MONAI · Nov 4, 2022 · 3b0a4ae · 3b0a4ae
2 parents 4459654 + 0d792f2
commit 3b0a4ae
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/src/Plugins/AWSS3/StorageAdminService.cs b/src/Plugins/AWSS3/StorageAdminService.cs
@@ -34,5 +34,6 @@ public class StorageAdminService : IStorageAdminService
         public Task<bool> HasConnectionAsync() => throw new NotImplementedException();
 
         public Task RemoveUserAsync(string username) => throw new NotImplementedException();
+        public Task<bool> SetConnectionAsync() => throw new NotImplementedException();
     }
 }
diff --git a/src/Plugins/MinIO/MinIoAdminHealthCheck.cs b/src/Plugins/MinIO/MinIoAdminHealthCheck.cs
@@ -36,8 +36,13 @@ public MinIoAdminHealthCheck(IStorageAdminService storageAdminService, ILogger<M
         {
             try
             {
-                var hasConnection = await _storageAdminService.HasConnectionAsync();
-                var connectionResult = await _storageAdminService.GetConnectionAsync();
+                var hasConnection = await _storageAdminService.HasConnectionAsync().ConfigureAwait(false);
+                if (hasConnection is false)
+                {
+                    await _storageAdminService.SetConnectionAsync().ConfigureAwait(false);
+                }
+
+                var connectionResult = await _storageAdminService.GetConnectionAsync().ConfigureAwait(false);
                 var joinedResult = string.Join("\n", connectionResult);
 
                 var roDict = new ReadOnlyDictionary<string, object>(new Dictionary<string, object>() { { "MinoAdminResult", joinedResult } });

diff --git a/src/Storage/API/IStorageAdminService.cs b/src/Storage/API/IStorageAdminService.cs
@@ -56,5 +56,11 @@ public interface IStorageAdminService
         /// </summary>
         /// <returns></returns>
         Task<bool> HasConnectionAsync();
+
+        /// <summary>
+        /// Cread the Admin alias.
+        /// </summary>
+        /// <returns>Bool</returns>
+        Task<bool> SetConnectionAsync();
     }
 }