Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to .NET 8 #281

Merged
merged 9 commits into from
Jan 2, 2024
Merged

Upgrade to .NET 8 #281

merged 9 commits into from
Jan 2, 2024

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Dec 20, 2023 •
edited
Loading

Description

Upgrade to .NET 8.0 LTS.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@mocsharp
Upgrade to .NET 8
1f5b2a7 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Dec 20, 2023
@mocsharp mocsharp added this to the 0.3.0 milestone Dec 20, 2023
@mocsharp mocsharp requested a review from neildsouth December 20, 2023 01:09
@mocsharp mocsharp self-assigned this Dec 20, 2023
@mocsharp
Fix CI, remove Serialization, update licenses
df99963 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Fix CI test filtering
14e042c 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Pin minio version
f72d1b3 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Fix minio healthcheck
898953f 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Update minio version
a2a2c0a 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Update java to v17
64563ec 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Update codecov dir
4427069 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6896810) 78.82823% compared to head (9361c38) 79.40979%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #281         +/-   ##
===================================================
+ Coverage   78.82823%   79.40979%   +0.58155%     
===================================================
  Files             38          38                 
  Lines           1502        1491         -11     
  Branches          78          78                 
===================================================
  Hits            1184        1184                 
+ Misses           279         268         -11     
  Partials          39          39
Flag Coverage Δ
unittests 79.40979% <100.00000%> (+0.58155%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Plugins/MinIO/MinIoClientFactory.cs 42.85714% <100.00000%> (ø)
src/Plugins/MinIO/MinIoStartup.cs 88.88889% <ø> (ø)
src/Plugins/MinIO/MinIoStorageService.cs 68.63469% <ø> (ø)
...ns/MinIO/Tests/Integration/MinIoHealthCheckTest.cs 100.00000% <100.00000%> (ø)
...ins/MinIO/Tests/Integration/MinIoStorageFixture.cs 67.44186% <ø> (ø)
...MinIO/Tests/Integration/MinIoStorageServiceTest.cs 99.15966% <100.00000%> (ø)
...MinIO/Tests/Integration/StorageAdminServiceTest.cs 91.11111% <100.00000%> (ø)
...gins/MinIO/Tests/Unit/MinIoAdminHealthCheckTest.cs 100.00000% <100.00000%> (ø)
...c/Plugins/MinIO/Tests/Unit/MinIoHealthCheckTest.cs 100.00000% <100.00000%> (ø)
src/Plugins/MinIO/Tests/Unit/MinIoStartupTest.cs 100.00000% <ø> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6896810...9361c38. Read the comment docs.

@mocsharp
Update test param
9361c38 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit fe9414b into develop Jan 2, 2024
12 of 13 checks passed
@mocsharp mocsharp deleted the vchang/net8 branch January 2, 2024 18:02
mocsharp added a commit that referenced this pull request Jan 2, 2024
@mocsharp
Upgrade to .NET 8 (#281)
347c2ab 
* Upgrade to .NET 8

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the build label Jan 2, 2024
mocsharp added a commit that referenced this pull request Jan 5, 2024
@mocsharp
Release/1.0.0 (#284)
654e943 
+semver: major

* Update license approvals

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Throw any error from MinIO with ListObject APIs (#214)

* Throw any error from MinIO when listing objects
* Capture ListObjectsAsync exceptions in VerifyObjectExistsAsync
* Configure minio client timeout
* Throw VerifyObjectsException on error
* Convert MinIO exception with custom exceptions
* Update API doc

* Upgrade to .NET 8 (#281)

* Upgrade to .NET 8


Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added enhancement New feature or request and removed build labels Jan 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

mocsharp added a commit that referenced this pull request Jun 12, 2024
@mocsharp @dependabot @neildsouth
Release/1.0.1 (#329)
3478f9b 
* Bump actions/cache from 3.2.2 to 3.3.0 (#190)

Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.3.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.2.2...v3.3.0)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump gittools/actions from 0.9.15 to 0.10.2 (#189)

Bumps [gittools/actions](https://github.com/gittools/actions) from 0.9.15 to 0.10.2.
- [Release notes](https://github.com/gittools/actions/releases)
- [Commits](GitTools/actions@v0.9.15...v0.10.2)

---
updated-dependencies:
- dependency-name: gittools/actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump AWSSDK.SecurityToken from 3.7.101.22 to 3.7.101.24 (#194)

Bumps [AWSSDK.SecurityToken](https://github.com/aws/aws-sdk-net) from 3.7.101.22 to 3.7.101.24.
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

---
updated-dependencies:
- dependency-name: AWSSDK.SecurityToken
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump AWSSDK.S3 from 3.7.103.24 to 3.7.103.27 (#199)

Bumps [AWSSDK.S3](https://github.com/aws/aws-sdk-net) from 3.7.103.24 to 3.7.103.27.
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

---
updated-dependencies:
- dependency-name: AWSSDK.S3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove reference of .NET packages

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update license approvals

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Remove duplicate section of CodeQL scan

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* fix up ci

Signed-off-by: Neil South <neil.south@answerdigital.com>

* Throw any error from MinIO with ListObject APIs (#214)

* Throw any error from MinIO when listing objects
* Capture ListObjectsAsync exceptions in VerifyObjectExistsAsync
* Configure minio client timeout
* Throw VerifyObjectsException on error
* Convert MinIO exception with custom exceptions
* Update API doc


Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update dependencies (#241)

+semver: patch

* Update dependencies: AWSSDK, GuardClauses, FluentAssertions, Moq, xunit, coverlet
* Update MinIo
* Update .NET6 libs
* Update licenses and dependency decisions

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Remove unused references (#243)

* Remove unused references
* Cleanup licenses
* Update Moq

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Upgrade to .NET 8 (#281)

* Upgrade to .NET 8

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Bump codecov/codecov-action from 3.1.1 to 3.1.4 (#232)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3.1.1...v3.1.4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump apache/skywalking-eyes from 0.4.0 to 0.5.0 (#245)

Bumps [apache/skywalking-eyes](https://github.com/apache/skywalking-eyes) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/apache/skywalking-eyes/releases)
- [Changelog](https://github.com/apache/skywalking-eyes/blob/main/CHANGES.md)
- [Commits](apache/skywalking-eyes@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: apache/skywalking-eyes
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 3 to 4 (#246)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/cache from 3.3.0 to 3.3.2 (#247)

Bumps [actions/cache](https://github.com/actions/cache) from 3.3.0 to 3.3.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.3.0...v3.3.2)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/upload-artifact from 3.1.2 to 4.0.0 (#278)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3.1.2...v4.0.0)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update mc commands (#328)

* Update mc commands

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update dependencies

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Remove windows build

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update minio client for testing

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update dependency versions

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update 3rd party licenses and copyright

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update licenses

Signed-off-by: Victor Chang <vicchang@nvidia.com>

---------

Signed-off-by: Victor Chang <vicchang@nvidia.com>

* Update codecov/codecov-action@v4.4.1

Signed-off-by: Victor Chang <mocsharp@users.noreply.github.com>

* Fix codecov copyright

Signed-off-by: Victor Chang <vicchang@nvidia.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Victor Chang <mocsharp@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Neil South <neil.south@answerdigital.com>
Co-authored-by: Neil South <104848880+neildsouth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neildsouth neildsouth neildsouth approved these changes

Assignees

@mocsharp mocsharp

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request .NET Pull requests that update .net code
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mocsharp @neildsouth