Updated training script for torch prescriptors to allow config #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyoungday
commented
Mar 19, 2024
There was a problem hiding this comment.
Basic config file similar to the ESP one.
danyoungday
commented
Mar 19, 2024
| parser.add_argument("--config_path", type=str, required=True) | ||
| args = parser.parse_args() | ||
| with open(Path(args.config_path), "r", encoding="utf-8") as f: | ||
| config = json.load(f) |
There was a problem hiding this comment.
The only argument we need is a config file. More customizability can come in the subset of data we use, what type of predictor we use, etc. but for now this simple one works
danyoungday
commented
Mar 19, 2024
| "hidden_size": 16, | ||
| "out_size": len(constants.RECO_COLS)} | ||
| if "seed_dir" in config["evolution_params"].keys(): | ||
| config["evolution_params"]["seed_dir"] = Path(config["evolution_params"]["seed_dir"]) |
There was a problem hiding this comment.
Convert seed dir string into Path object here so that we don't have to do it inside the TorchPrescriptor object and can continue assuming that what gets passed in is a Path
ofrancon
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.