[feat] [#26] Home 화면 UI #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f545353)
easyhooon
reviewed
Apr 4, 2024
feature/home/src/main/kotlin/com/unifest/android/feature/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
easyhooon
reviewed
Apr 4, 2024
feature/home/src/main/kotlin/com/unifest/android/feature/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
|
modifier = Modifier. ~ 로 옵션 붙히실때, 옵션이 하나뿐이라면 한줄로 쓰는게 좋을거같슴니다 |
LazyRow의 Row 내에서 시작지점을 고정하고 아이템이 많아지면 내부적으로 뷰를 수정해야할것같습니다. 현재는 아이템의 개수를 6개 이렇게 늘려버리면 뷰 전체가 변경되네요 |
easyhooon
reviewed
Apr 4, 2024
feature/home/src/main/kotlin/com/unifest/android/feature/home/HomeScreen.kt
Show resolved
Hide resolved
|
그 밖에 Text 컴포저블도 내부 속성이 여러개일 경우 전부 개행해서 작성하는게 다른 컴포저블들과 통일성이 있어서 좋을거같습니다 |
easyhooon
reviewed
Apr 4, 2024
feature/home/src/main/kotlin/com/unifest/android/feature/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
|
LGTM! 수고하셨습니다 |
easyhooon
approved these changes
Apr 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
중복되는 버튼이 하나 보여서 컴포넌트로 UnifestOutlinedButton 을 하나 만들어뒀습니다