[feat] [#49] Menu 및 InterestedBooths 화면 구현 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b2b1916) (cherry picked from commit 455d9f19568cfb8a453aaa48316aaae607f2df5a)
(cherry picked from commit bd69a5d) (cherry picked from commit 26c17707925206bc71972f3d5a2cb3805c3404d4)
(cherry picked from commit b1af7e9) (cherry picked from commit d47ff9a77df4dd154132a94ada754e9cc39de483)
(cherry picked from commit 11d57de) (cherry picked from commit 779f9605840ea25de74b308569ec78ad459b0d76)
(cherry picked from commit cbacf80) (cherry picked from commit d1602d76fed02f005a2c42124b0f43fbd00e4905)
(cherry picked from commit 0f5c3d6cb1d1c8440753bcd790faf403f2957308)
(cherry picked from commit 7da62be9d93520bed5017338d66ea54eff020986)
(cherry picked from commit 5324d61661e43dee367ddfa5e7a353338c6b16b0)
(cherry picked from commit 73cf90426f57975a19bf5feef03d6230b5200a86)
이거 인트루로 가는게 기존 계획이었는데, Map 화면에서 쓰이는 학교/축제 BottomSheet 가 열리는 것으로 계획이 변경된 것으로 알고있습니다. 해당 바텀시트를 쓰면 open/close 하면 되서 별도로 네비게이션을 동작시킬필요가 없구요 |
메뉴를 클릭했을 때에 대한 아이콘을 추가해야 할 것 같네요 제가 설정할땐 해당 아이콘이 없었어서 |
easyhooon
reviewed
Apr 12, 2024
feature/menu/src/main/kotlin/com/unifest/android/feature/menu/viewmodel/MenuViewModel.kt
Outdated
Show resolved
Hide resolved
easyhooon
reviewed
Apr 12, 2024
| style = Title3, | ||
| ) | ||
| TextButton( | ||
| onClick = { onNavigateToIntro() }, |
There was a problem hiding this comment.
onClick = onNavigateToIntro 로 더 간단하게 쓸수있을것같은데 일단 해당 동작에 대해선 확실하게 정하고 넘어가야할 것 같네요
There was a problem hiding this comment.
넵 요부분은 그럼 석준씨 대답보고 수정하겠습니다
easyhooon
reviewed
Apr 12, 2024
feature/menu/src/main/kotlin/com/unifest/android/feature/menu/MenuScreen.kt
Outdated
Show resolved
Hide resolved
easyhooon
reviewed
Apr 12, 2024
feature/menu/src/main/kotlin/com/unifest/android/feature/menu/MenuScreen.kt
Outdated
Show resolved
Hide resolved
easyhooon
reviewed
Apr 12, 2024
feature/menu/src/main/kotlin/com/unifest/android/feature/menu/MenuScreen.kt
Outdated
Show resolved
Hide resolved
easyhooon
reviewed
Apr 12, 2024
...-booth/src/main/kotlin/com/unifest/android/feature/interested_booth/InterestedBoothScreen.kt
Show resolved
Hide resolved
|
아이템이 삭제되고 추가될때에 대한 애니메이션을 추가하면 좋을 것 같은데 이건 구현할때 추가하면 될 것 같아요 |
|
관심 부스 목록 화면에서 뒤로가기 했을 때, 메뉴화면으로 돌아올 수 있도록, 구현해주세여 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
나의 관심학교 추가를 누르면 인트로로 가게 연결해두었습니다. 이때 추가완료를 누르면 NavigatetoMain 을 따라 홈 화면으로 가는데, 메뉴화면으로 가게 생각해봐야겠습니다(제가)