[feat] 홈과 인트로 화면의 디자인 및 논의내역 수정 사항 #78
Merged
+430
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyhooon
reviewed
Apr 15, 2024
| import com.unifest.android.core.domain.entity.FestivalEventEntity | ||
| import com.unifest.android.core.domain.entity.IncomingFestivalEventEntity | ||
| import kotlinx.collections.immutable.ImmutableList | ||
| import kotlinx.collections.immutable.persistentListOf | ||
| import java.time.LocalDate |
There was a problem hiding this comment.
해당 달력 라이브러리 내에서 사용하는 시간 관련 라이브러리가 java.time 이 아니라면 kotlinx.datetime 사용하는걸 권장합니다
https://github.com/Kotlin/kotlinx-datetime
easyhooon
reviewed
Apr 15, 2024
|
|
||
| data class HomeUiState( | ||
| val incomingEvents: ImmutableList<IncomingFestivalEventEntity> = persistentListOf(), | ||
| val festivalEvents: ImmutableList<FestivalEventEntity> = persistentListOf(), | ||
| val festivalSearchText: TextFieldValue = TextFieldValue(), | ||
| val interestedFestivals: MutableList<Festival> = mutableListOf(), |
There was a problem hiding this comment.
이거 아마 제가 이번 pr 에 수정했을것같긴한데 interested 남아있는거 liked 로 수정부탁드려여
|
리뷰 완료했습니다. 충돌나는거랑 리뷰 반영부탁드려용 |
|
|
|
탭간격 줄이는 부분은 못찾았는데 이슈에 올려두겠습니다!! |
easyhooon
approved these changes
Apr 16, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기본적으로 어제 대화한 내역들을 반영했습니다. 인트로 화면에서 맵화면으로 이동하는부분은 지훈님이 권한 설정하시면서 flow에 따라 작성하실거같아서 빼뒀습니다.
인트로에서 선택된 학교들을 LazyRow로 변경했는데, 기존의 LazyVerticalGrid는 한줄에 3개의 아이템이 균등하게 분배되었던 반면 현재는 변경이후 직접 크기를 입력해서 카드를 작성했습니다. 폭을 계산해서 padding만큼을 빼고 /3으로 값을 설정할까도 싶기도..
홈화면의 캘린더와 UiState, ViewModel을 연동해서 오늘의 축제일정이 아니라 4월 15일의 축제일정처럼 선택된 날짜가 나오게 변경했습니다.