Skip to content

bug/issue 1402 add missing compilation constructor prop #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented May 16, 2025

Related Issue

resolves #1402

Documentation

  1. Need to update the docs for this - document correct / updated signature of custom elements for SSR pages constructor props www.greenwoodjs.dev#209

Summary of Changes

  1. Refactor constructor props to be an object
  2. Add compilation as a property of said object
  3. Update SsrRouteHandler types

@thescientist13 thescientist13 added bug Something isn't working documentation Greenwood specific docs CLI breaking Types(cript) Requires type definition or TypeScript related work / documentation labels May 16, 2025
@thescientist13 thescientist13 force-pushed the bug/issue-1402-add-missing-compilation-constructor-prop branch from 8658be4 to 7fed46d Compare May 25, 2025 16:46
@thescientist13 thescientist13 merged commit dee1a18 into master May 25, 2025
12 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1402-add-missing-compilation-constructor-prop branch May 25, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working CLI documentation Greenwood specific docs Types(cript) Requires type definition or TypeScript related work / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR pages and layouts using custom HTML element with constructor params returns undefined for compilation object
1 participant