Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose commit/rollback via bridge apis #193

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Expose commit/rollback via bridge apis #193

merged 8 commits into from
Apr 2, 2024

Conversation

JoeCap08055
Copy link
Collaborator

Goal

The goal of this PR is to expose GraphSDK's commit/rollback functionality to the Bridge APIs (currently only available via native Rust API)

  • Add disable_auto_commit flag to ActionOptions, have apply_actions honor it
  • Expose commit/rollback to Node.js, Java, and C APIs

Closes #192

Checklist

  • Tests added

@JoeCap08055
Copy link
Collaborator Author

I'll sync this from main once #191 is merged

@saraswatpuneet
Copy link
Collaborator

Should we do this after the stable release?

aramikm
aramikm approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding this. A couple of nits and I think we might also need a small test on java side to ensure jni works

.cargo-deny.toml Show resolved Hide resolved
bridge/node/src/api.rs Show resolved Hide resolved
@JoeCap08055 JoeCap08055 merged commit a04476c into main Apr 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramikm aramikm aramikm approved these changes

@saraswatpuneet saraswatpuneet Awaiting requested review from saraswatpuneet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bridge APIs do not expose commit/rollback
3 participants
@JoeCap08055 @saraswatpuneet @aramikm