-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the repo to project liberty labs #212
Conversation
@@ -7,7 +7,7 @@ UNAME := $(shell uname) | |||
|
|||
PROTOC := protoc | |||
ifeq ($(UNAME), Darwin) | |||
PROTOC = /opt/homebrew/opt/protobuf@27/bin/protoc | |||
PROTOC = /opt/homebrew/opt/protobuf@21/bin/protoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was showing that experimental issue which I thought it was solved. So had to role back to the previous version we were using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good--I had some concerns about doing a major version bump 1.1.x
-> 2.0.0
, but since anyone depending on the package will have to make a source change to pull from the new repo/published name anyway, I think it's fine.
+1 The Java package name change pushes it over the edge for me. |
Goal
The goal of this PR is to update the repo to ProjectLibertyLabs
Closes #211
Changes
io.amplica
java toio.projectliberty
@dsnp/graph-sdk
->@projectlibertylabs/graph-sdk
NODE_AUTH_TOKEN
->NPM_AUTH_TOKEN
in GitHub Actions2.0.0
amplica