fix keyboard navigation issues with windowTopMenu #1493
Annotations
10 errors and 1 warning
|
__tests__/src/components/WindowTopMenu.test.js#L40
AssertionError: expected [ <li …(4)>…(2)</li>, …(2) ] to have a length of 5 but got 3
- Expected
+ Received
- 5
+ 3
❯ __tests__/src/components/WindowTopMenu.test.js:40:23
|
|
src/state/actions/window.js#L170
TypeError: Cannot destructure property 'thumbnailNavigationId' of 'windows[windowId]' as it is undefined.
❯ src/state/actions/window.js:170:13
❯ node_modules/redux-thunk/dist/redux-thunk.mjs:5:14
❯ boundActionCreators.<computed> node_modules/react-redux/src/utils/bindActionCreators.ts:12:47
❯ handleChange src/components/WindowThumbnailSettings.js:43:37
❯ onClick src/components/WindowThumbnailSettings.js:53:28
❯ HTMLUnknownElement.callCallback node_modules/react-dom/cjs/react-dom.development.js:4164:14
❯ HTMLUnknownElement.#callDispatchEventListeners node_modules/happy-dom/src/event/EventTarget.ts:286:41
❯ HTMLUnknownElement.dispatchEvent node_modules/happy-dom/src/event/EventTarget.ts:121:35
❯ HTMLUnknownElement.dispatchEvent node_modules/happy-dom/src/nodes/element/Element.ts:1252:29
❯ HTMLUnknownElement.#goThroughDispatchEventPhases node_modules/happy-dom/src/event/EventTarget.ts:184:32
|
|
src/state/actions/window.js#L170
TypeError: Cannot destructure property 'thumbnailNavigationId' of 'windows[windowId]' as it is undefined.
❯ src/state/actions/window.js:170:13
❯ node_modules/redux-thunk/dist/redux-thunk.mjs:5:14
❯ boundActionCreators.<computed> node_modules/react-redux/src/utils/bindActionCreators.ts:12:47
❯ handleChange src/components/WindowThumbnailSettings.js:43:37
❯ onClick src/components/WindowThumbnailSettings.js:53:28
❯ HTMLUnknownElement.callCallback node_modules/react-dom/cjs/react-dom.development.js:4164:14
❯ HTMLUnknownElement.#callDispatchEventListeners node_modules/happy-dom/src/event/EventTarget.ts:286:41
❯ HTMLUnknownElement.dispatchEvent node_modules/happy-dom/src/event/EventTarget.ts:121:35
❯ HTMLUnknownElement.dispatchEvent node_modules/happy-dom/src/nodes/element/Element.ts:1252:29
❯ HTMLUnknownElement.#goThroughDispatchEventPhases node_modules/happy-dom/src/event/EventTarget.ts:184:32
|
|
__tests__/src/components/WindowViewSettings.test.js#L24
AssertionError: expected +0 to be 4 // Object.is equality
- Expected
+ Received
- 4
+ 0
❯ __tests__/src/components/WindowViewSettings.test.js:24:30
|
|
__tests__/src/components/WindowViewSettings.test.js#L32
TestingLibraryElementError: Unable to find an accessible element with the role "menuitem" and name `/Single/`
Here are the accessible roles:
presentation:
Name "":
<li
class="MuiListSubheader-root MuiListSubheader-gutters css-5qqijm-MuiListSubheader-root"
role="presentation"
/>
--------------------------------------------------
menubar:
Name "":
<ul
class="MuiList-root MuiList-padding css-1p75baz-MuiList-root-WindowViewSettings-option"
role="menubar"
tabindex="-1"
/>
--------------------------------------------------
menuitemradio:
Name "Single":
<li
aria-checked="true"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters Mui-selected Mui-focusVisible MuiMenuItem-root MuiMenuItem-gutters Mui-selected css-17lid5b-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="0"
/>
Name "Book":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Scroll":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Gallery":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
--------------------------------------------------
Ignored nodes: comments, script, style
<body>
<div>
<li
class="MuiListSubheader-root MuiListSubheader-gutters css-5qqijm-MuiListSubheader-root"
role="presentation"
>
View
</li>
<ul
class="MuiList-root MuiList-padding css-1p75baz-MuiList-root-WindowViewSettings-option"
role="menubar"
tabindex="-1"
>
<li
aria-checked="true"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters Mui-selected Mui-focusVisible MuiMenuItem-root MuiMenuItem-gutters Mui-selected css-17lid5b-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="0"
>
<label
class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementBottom css-1c1s55e-MuiFormControlLabel-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-colorSecondary MuiSvgIcon-fontSizeMedium css-1hsd4a3-MuiSvgIcon-root"
data-testid="CropOriginalSharpIcon"
fill="currentcolor"
focusable="false"
value="single"
viewBox="0 0 24 24"
>
<path
d="M21 3H3v18h18zm-2 16H5V5h14zm-5.04-6.71-2.75 3.54-1.96-2.36L6.5 17h11z"
/>
</svg>
<span
class="MuiTypography-root MuiTypography-body1 MuiFormControlLabel-label css-vvl3q8-MuiTypography-root"
>
Single
</span>
</label>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</li>
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
>
<label
class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementBottom css-1c1s55e-MuiFormControlLabel-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1m9ymud-MuiSvgIcon-root"
fill="currentcolor"
focusable="false"
height="24"
value="book"
viewBox="0 0 24 24
|
|
__tests__/src/components/WindowViewSettings.test.js#L37
TestingLibraryElementError: Unable to find an accessible element with the role "menuitem" and name `/Book/`
Here are the accessible roles:
presentation:
Name "":
<li
class="MuiListSubheader-root MuiListSubheader-gutters css-5qqijm-MuiListSubheader-root"
role="presentation"
/>
--------------------------------------------------
menubar:
Name "":
<ul
class="MuiList-root MuiList-padding css-1p75baz-MuiList-root-WindowViewSettings-option"
role="menubar"
tabindex="-1"
/>
--------------------------------------------------
menuitemradio:
Name "Single":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Book":
<li
aria-checked="true"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters Mui-selected Mui-focusVisible MuiMenuItem-root MuiMenuItem-gutters Mui-selected css-17lid5b-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="0"
/>
Name "Scroll":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Gallery":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
--------------------------------------------------
Ignored nodes: comments, script, style
<body>
<div>
<li
class="MuiListSubheader-root MuiListSubheader-gutters css-5qqijm-MuiListSubheader-root"
role="presentation"
>
View
</li>
<ul
class="MuiList-root MuiList-padding css-1p75baz-MuiList-root-WindowViewSettings-option"
role="menubar"
tabindex="-1"
>
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
>
<label
class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementBottom css-1c1s55e-MuiFormControlLabel-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="CropOriginalSharpIcon"
fill="currentcolor"
focusable="false"
value="single"
viewBox="0 0 24 24"
>
<path
d="M21 3H3v18h18zm-2 16H5V5h14zm-5.04-6.71-2.75 3.54-1.96-2.36L6.5 17h11z"
/>
</svg>
<span
class="MuiTypography-root MuiTypography-body1 MuiFormControlLabel-label css-vvl3q8-MuiTypography-root"
>
Single
</span>
</label>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</li>
<li
aria-checked="true"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters Mui-selected Mui-focusVisible MuiMenuItem-root MuiMenuItem-gutters Mui-selected css-17lid5b-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="0"
>
<label
class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementBottom css-1c1s55e-MuiFormControlLabel-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-colorSecondary MuiSvgIcon-fontSizeMedium css-9pfmda-MuiSvgIcon-root"
fill="currentcolor"
focusable="false"
height="24"
value="book"
viewBox="0 0 24 24"
|
|
__tests__/src/components/WindowViewSettings.test.js#L42
TestingLibraryElementError: Unable to find an accessible element with the role "menuitem" and name `/Scroll/`
Here are the accessible roles:
presentation:
Name "":
<li
class="MuiListSubheader-root MuiListSubheader-gutters css-5qqijm-MuiListSubheader-root"
role="presentation"
/>
--------------------------------------------------
menubar:
Name "":
<ul
class="MuiList-root MuiList-padding css-1p75baz-MuiList-root-WindowViewSettings-option"
role="menubar"
tabindex="-1"
/>
--------------------------------------------------
menuitemradio:
Name "Single":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Book":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Scroll":
<li
aria-checked="true"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters Mui-selected Mui-focusVisible MuiMenuItem-root MuiMenuItem-gutters Mui-selected css-17lid5b-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="0"
/>
Name "Gallery":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
--------------------------------------------------
Ignored nodes: comments, script, style
<body>
<div>
<li
class="MuiListSubheader-root MuiListSubheader-gutters css-5qqijm-MuiListSubheader-root"
role="presentation"
>
View
</li>
<ul
class="MuiList-root MuiList-padding css-1p75baz-MuiList-root-WindowViewSettings-option"
role="menubar"
tabindex="-1"
>
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
>
<label
class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementBottom css-1c1s55e-MuiFormControlLabel-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="CropOriginalSharpIcon"
fill="currentcolor"
focusable="false"
value="single"
viewBox="0 0 24 24"
>
<path
d="M21 3H3v18h18zm-2 16H5V5h14zm-5.04-6.71-2.75 3.54-1.96-2.36L6.5 17h11z"
/>
</svg>
<span
class="MuiTypography-root MuiTypography-body1 MuiFormControlLabel-label css-vvl3q8-MuiTypography-root"
>
Single
</span>
</label>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</li>
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
>
<label
class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementBottom css-1c1s55e-MuiFormControlLabel-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1m9ymud-MuiSvgIcon-root"
fill="currentcolor"
focusable="false"
height="24"
value="book"
viewBox="0 0 24 24"
width="24"
xmlns="http://www.w3.org/2000/sv
|
|
__tests__/src/components/WindowViewSettings.test.js#L47
TestingLibraryElementError: Unable to find an accessible element with the role "menuitem" and name `/Gallery/`
Here are the accessible roles:
presentation:
Name "":
<li
class="MuiListSubheader-root MuiListSubheader-gutters css-5qqijm-MuiListSubheader-root"
role="presentation"
/>
--------------------------------------------------
menubar:
Name "":
<ul
class="MuiList-root MuiList-padding css-1p75baz-MuiList-root-WindowViewSettings-option"
role="menubar"
tabindex="-1"
/>
--------------------------------------------------
menuitemradio:
Name "Single":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Book":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Scroll":
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
/>
Name "Gallery":
<li
aria-checked="true"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters Mui-selected Mui-focusVisible MuiMenuItem-root MuiMenuItem-gutters Mui-selected css-17lid5b-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="0"
/>
--------------------------------------------------
Ignored nodes: comments, script, style
<body>
<div>
<li
class="MuiListSubheader-root MuiListSubheader-gutters css-5qqijm-MuiListSubheader-root"
role="presentation"
>
View
</li>
<ul
class="MuiList-root MuiList-padding css-1p75baz-MuiList-root-WindowViewSettings-option"
role="menubar"
tabindex="-1"
>
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
>
<label
class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementBottom css-1c1s55e-MuiFormControlLabel-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="CropOriginalSharpIcon"
fill="currentcolor"
focusable="false"
value="single"
viewBox="0 0 24 24"
>
<path
d="M21 3H3v18h18zm-2 16H5V5h14zm-5.04-6.71-2.75 3.54-1.96-2.36L6.5 17h11z"
/>
</svg>
<span
class="MuiTypography-root MuiTypography-body1 MuiFormControlLabel-label css-vvl3q8-MuiTypography-root"
>
Single
</span>
</label>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</li>
<li
aria-checked="false"
class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-jjngcl-MuiButtonBase-root-MuiMenuItem-root-WindowViewSettings-option"
role="menuitemradio"
tabindex="-1"
>
<label
class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementBottom css-1c1s55e-MuiFormControlLabel-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1m9ymud-MuiSvgIcon-root"
fill="currentcolor"
focusable="false"
height="24"
value="book"
viewBox="0 0 24 24"
width="24"
xmlns="http://www.w3.org/2000/s
|
|
__tests__/src/components/WindowViewSettings.test.js#L55
AssertionError: expected +0 to be 4 // Object.is equality
- Expected
+ Received
- 4
+ 0
❯ __tests__/src/components/WindowViewSettings.test.js:55:30
|
|
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
The logs for this run have expired and are no longer available.
Loading