Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translate hook to plugins #4099

Conversation

Marcel-Tronco
Copy link

Updating my mirador setup to the recent 4.0 alpha I ran into problems using the mirador-image-plugin, because it didn't get the translation function it expected as a prop t. This commit solved it for me locally.

Feel free to use this.

Best

@cbeer
Copy link
Collaborator

cbeer commented Feb 10, 2025

Thanks for looking into this. @marlo-longley and I were talking about this problem over on #4095, and this seems like the option 2 I offered over there. We shipped #4098 (option 1) as an alternative to this that hopefully works better with hooks or more complicated plugins (otherwise you'd have to pass the plugin-provided t to any subcomponents, we think?).

This will take a little update in any plugins (e.g. ProjectMirador/mirador-dl-plugin#82) but Mirador 4 already requires some updates so we'll just include them in the release notes soon.

Thanks again

@cbeer cbeer closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants