Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom domain name option #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brian-rose
Copy link
Member

As discussed in #129, the new deployment action doesn't support a CNAME argument for deployment to custom domains. But we don't need this. It's a one-time step to put a CNAME file at the root of the gh-pages branch, and we are only using this for two repositories (Foundations and Cookbook Gallery).

This PR removes the cname input option for the deploy-book.yaml workflow.

We'll need to tweak the workflow code that calls this from the Foundations and Cookbook Gallery repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant