Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookbook gallery with wavelet-cookbook per #216 #217

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pythia-pr-machine[bot]
Copy link
Contributor

Update cookbook gallery as requested in #216. Closes #216.

@pythia-pr-machine pythia-pr-machine bot requested a review from a team as a code owner December 23, 2024 23:28
@pythia-pr-machine pythia-pr-machine bot requested review from brian-rose and mgrover1 and removed request for a team December 23, 2024 23:28
Copy link

github-actions bot commented Dec 23, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 3bb9914
✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-gallery/_preview/217

@erogluorhan erogluorhan self-requested a review January 9, 2025 22:23
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-rose @mgrover1 @cyschneck

I've given this cookbook a review and really enjoyed the content; however, I need to note one thing:

The basics of wavelets and most of the example workflows are covered through audio data rather than geosciences. The only application to the Earth system sciences showcased in it is the last part.

Since I wasn't there at the Cookoff 2024, I might be missing some context about this, which you all may have already discussed.

What do you think?

@erogluorhan erogluorhan changed the title Update cookbook gallery per #216 Update cookbook gallery with wavelet-cookbook per #216 Jan 9, 2025
@cyschneck
Copy link

The first two sections are more introductory, I was going to continue to add more workflows to use geoscience data, but wanted to meet the AMS deadline for the cookbook. I have some WIP for ocean work (I was looking at this sea surface heights data from NOAA) and some data from NSIDC (like sea ice).

Would it make more sense if I moved the first two workflows into the Foundations section? This would keep the geoscience workflows in the main section

@erogluorhan
Copy link
Member

erogluorhan commented Jan 10, 2025

I think covering even the Foundations through some kind of geoscience data might be more favorable for Pythia's training purposes but I don't think we have ever documented any constraints as such, so I am curious about others' thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Gallery with Wavelet Cookbook
2 participants