Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: intake-esgf + rooki notebook #36

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

nocollier
Copy link
Collaborator

This PR is needed as the WPS address in there now is not functional. While I was at it, I took a pass and cleaned up some things I found as well:

  • Zach has changed the endpoint to something that looks more consistent
  • Removed a redundant cat = ESGFCatalog()
  • Added data_node = "esgf-node.ornl.gov" to the search. ORNL has info about holdings elsewhere so it is actually needed to make sure we don't try to load data that isn't at ORNL
  • Renamed the dataset_id to a rooki_id, dataset_id is something else in ESGF parlance and I thought it wise to avoid confusion
  • The rooki function didn't use the argument, it just used the first id, i.e. dataset_ids[0]
  • Expanded the explanation in several places

Copy link

github-actions bot commented Oct 24, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: baa8496
✅ Deployment Preview URL: https://ProjectPythia.github.io/esgf-cookbook/_preview/36

@nocollier nocollier changed the title Updates to intake-esgf + rooki notebook FIX: intake-esgf + rooki notebook Oct 24, 2024
@nocollier
Copy link
Collaborator Author

@mgrover1 I couldn't check the preview as it was returning 404 but it renders locally for me.

Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - let's merge and see what it renders like on the main branch

@mgrover1 mgrover1 merged commit 4f19ea6 into ProjectPythia:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants