-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for build previews with GHA and Netlify #166
Add documentation for build previews with GHA and Netlify #166
Conversation
…io into use-netlify-for-preview
This reads well but I have not actually tried to follow the steps. I won't have time to do that until next Monday. Thanks for putting this together @andersy005 ! |
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 52bac9a |
The new GitHub Actions + Netlify workflow is working :).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few notes:
- Under "Step 3: Update site settings", I think screenshot 2 out of 3 ought to have a red box around the "Edit settings" button for clarity and consistency
- The example script with the
deploy_site
workflow is a little bit inconsistent with the actualdeploy_site
workflow in this repository (projectpythia.github.io/.github/workflows/ci.yaml
). The filename is different and some of the details are different. - Similarly, the example
preview_site
script is inconsistent with theprojectpythia.github.io/.github/workflows/preview.yaml
. I think we just need to add the extra if statements that came with Preview PRs via Netlify + GitHub Actions #167 - In "Step 6: Create GitHub Action secrets", can we just clarify that
NETLIFY_SITE_ID
in the GitHub action is the same thing asAPI ID
in the Netlify site settings.
Hey everyone. |
~~Quick update: I was indeed able to fix my problem by reactivating the build process and creating a site. I assume there is a better way to do this from the command line though? Maybe just upload a dummy file, so that something is 'there'. ~~ |
Yep. I turned them off. |
Okay... My next hunch is that when you added your Netlify credentials as GitHub Secrets, you may have inadvertently added a newline at the end of your keys and this ends up messing the HTTP headers during the connection to the Netlify. Can you reset those and re-trigger your GitHub workflow to see if the issue goes away? |
So I did that, but it also seems as if an older PR (yesterday night) built successfully. I wonder if this was a slip up on the netlify side? Thanks so much for this great tutorial! |
I was about to mention this :) (Just saw logs from your latest, successful builds). Yeah, it's likely a glitch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo that I could find. I haven't verified that this works, but the text looks good.
Co-authored-by: Kevin Paul <kpaul@ucar.edu>
…io into use-netlify-for-preview
@kmpaul & @brian-rose, I addressed your comments/feedback. Let me know if I missed anything... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @andersy005!
😍 |
Towards ProjectPythia/pythia-foundations#85. This PR is related to #167