Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why Matplotlib? Section #235

Merged
merged 11 commits into from
Mar 1, 2022
Merged

Why Matplotlib? Section #235

merged 11 commits into from
Mar 1, 2022

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Feb 28, 2022 •
edited
Loading

Adds a seciton on "Why Matplotlib" to the first matplotlib chapter.

Closes #138
Related to #234

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: d666354
✅ Deployment Preview URL: https://621d763a5b087078376c5d18--pythia-foundations.netlify.app

@jukent jukent marked this pull request as ready for review February 28, 2022 20:27
@jukent jukent requested a review from a team as a code owner February 28, 2022 20:27
@jukent jukent requested review from cjcardinale, mgrover1 and brian-rose and removed request for a team February 28, 2022 20:27
mgrover1
mgrover1 approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic overview!

@jukent jukent closed this Feb 28, 2022
@jukent jukent reopened this Feb 28, 2022
@jukent
Copy link
Contributor Author

jukent commented Feb 28, 2022

Just moved this section from the first matplotlib sub-chapter to the matplotlib.md page

brian-rose
brian-rose reviewed Feb 28, 2022
View reviewed changes
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @jukent!

I agree this "Why?" narrative belongs here on the section landing page rather than in a notebook.

I suggested a few edits here. In addition, I think it would be natural to drop in the Matplotlib logo on this landing page.

core/matplotlib.md Outdated Show resolved Hide resolved
core/matplotlib.md Outdated Show resolved Hide resolved
core/matplotlib.md Outdated Show resolved Hide resolved
core/matplotlib.md Outdated Show resolved Hide resolved
core/matplotlib.md Outdated Show resolved Hide resolved
jukent and others added 4 commits February 28, 2022 18:12
@jukent @brian-rose
Update core/matplotlib.md
6145a67 
Co-authored-by: Brian Rose <brose@albany.edu>
@jukent @brian-rose
Update core/matplotlib.md
859e1f4 
Co-authored-by: Brian Rose <brose@albany.edu>
@jukent @brian-rose
Update core/matplotlib.md
8b49381 
Co-authored-by: Brian Rose <brose@albany.edu>
@jukent @brian-rose
Update core/matplotlib.md
52fd214 
Co-authored-by: Brian Rose <brose@albany.edu>
@jukent
Copy link
Contributor Author

jukent commented Mar 1, 2022 •
edited
Loading

Thanks @brian-rose ! I've added the Matplotlib logo now

jukent and others added 2 commits February 28, 2022 18:15
@jukent
add matplotlib logo
da48809
@jukent @brian-rose
Update core/matplotlib.md
d666354 
Co-authored-by: Brian Rose <brose@albany.edu>
@jukent jukent requested a review from brian-rose March 1, 2022 01:18
brian-rose
brian-rose approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@brian-rose brian-rose merged commit 3a04597 into ProjectPythia:main Mar 1, 2022
@brian-rose brian-rose mentioned this pull request Mar 1, 2022
Closed
@jukent jukent deleted the matplotlib branch March 1, 2022 14:50
@jukent jukent added the content Content related issue label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

@brian-rose brian-rose brian-rose approved these changes

@cjcardinale cjcardinale Awaiting requested review from cjcardinale cjcardinale is a code owner automatically assigned from ProjectPythia/education

Assignees
No one assigned
Labels
content Content related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some discussion on "Why Matplotlib"
3 participants
@jukent @brian-rose @mgrover1