Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish Matplotlib content for consistency #238

Merged
merged 7 commits into from
Mar 3, 2022
Merged

Polish Matplotlib content for consistency #238

merged 7 commits into from
Mar 3, 2022

Conversation

brian-rose
Copy link
Member

This PR goes through all the Matplotlib content and makes a number of small tweaks for style and consistency, including

  • Rationalizing the titles and notebook file names
  • Consistent capitalization of the words "Matplotlib" and "Python" in the text
  • Adding the notebook output file animate.gif to the git ignore list
  • Tweaks to various links
  • Making the Matplotlib logo appear the same on each page

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 3a64805
✅ Deployment Preview URL: https://621e3c4dbe697c3f950682a0--pythia-foundations.netlify.app

@brian-rose
Copy link
Member Author

Closes #234

@brian-rose brian-rose marked this pull request as ready for review March 1, 2022 14:57
@brian-rose brian-rose requested a review from a team as a code owner March 1, 2022 14:57
@brian-rose brian-rose requested review from jukent and r-ford and removed request for a team March 1, 2022 14:57
jukent
jukent reviewed Mar 1, 2022
View reviewed changes
core/matplotlib.md Outdated Show resolved Hide resolved
@jukent
Copy link
Contributor

jukent commented Mar 1, 2022

@brian-rose Thanks for doing this! I just saw one irregularity on the matplotlib.md page that says we've taught 3D plotting. For some reason I'm unable to suggest an edit to that line.

brian-rose and others added 2 commits March 1, 2022 10:20
@brian-rose @jukent
Incorporate Julia's suggestion
962ad9f 
Co-authored-by: Julia Kent <46687291+jukent@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b8a0103 
for more information, see https://pre-commit.ci
@brian-rose
Copy link
Member Author

@brian-rose Thanks for doing this! I just saw one irregularity on the matplotlib.md page that says we've taught 3D plotting. For some reason I'm unable to suggest an edit to that line.

Thanks, good catch, I'll fix that now.

@brian-rose brian-rose requested a review from jukent March 1, 2022 15:32
jukent
jukent approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jukent jukent added the content Content related issue label Mar 2, 2022
r-ford
r-ford approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@r-ford r-ford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brian-rose brian-rose merged commit 98ebce7 into ProjectPythia:main Mar 3, 2022
@brian-rose brian-rose deleted the matplotlib-polish branch March 3, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-ford r-ford r-ford approved these changes

@jukent jukent jukent approved these changes

Assignees
No one assigned
Labels
content Content related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-rose @jukent @r-ford