Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support compound materials layers #540

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

adrianaghiozzi
Copy link
Contributor

@adrianaghiozzi adrianaghiozzi commented Apr 3, 2024

See related PRs in FusionMaterials, IMAS, and IMASDD. These changes allow build layers to be made of multiple materials, where each element in the material vector has a name and associated composition.

There are still a few things to be done:

  • Update build.tf.technology.material and build.oh.technology.material to also allow for compound materials and map those to the correct build layers in init_build
  • I've added a field called "fabrication" under dd.build.layer[:] that could eventually hold a symbol that describes the fabrication of the compound material itself - i.e. is it :homogenized, :layered, :corrugated, etc. The field is there but at the moment it's not hooked up to anything.
  • For now, I removed the setproperty! that disallows certain materials from being assigned to certain layers. We could eventually rethink this to be compatible with the compound layers
  • There is now a function in FusionMaterials called compound_material_property that calculates compound material properties as a simple linear combination of the materials it's comprised of. @bclyons12 will need an extension of this that works for materials connected in parallel rather than in series for vertical stability, and we could add that function to FusionMaterials for others to access

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bclyons12 Note that I put a sketchy fix here in the vertical stability actor just to avoid getting errors while I was testing this - as it is this would only take the first material in the list and set that as the vacuum vessel material. Eventually when you actually have compound layers you'll want to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant