Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull upstream to fix pow with decimals #4

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Pull upstream to fix pow with decimals #4

wants to merge 30 commits into from

Conversation

BogdanIrimie
Copy link

Rebased on upstream because it fixes pow with decimal numbers shopspring#55 (comment)

VadimKulagin and others added 29 commits December 27, 2023 15:53
@VadimKulagin
Allocate new(big.Int) in Copy method to deeply clone it (shopspring#278)
6926256
@mwoss
Reformat documentation to current go standard
88705b7
@mwoss
Add implementation of natural logarithm (shopspring#339)
12e9241 
* Add initial implementation of natural logarithm
* Add constApproxmation struct to represent mathematical constants with their approximations
@mwoss
Update Github Actions libraries to latest working version (shopspring…
304c9d6 
…#340)

* Update Github Actions libraries to the latest working version
* Update badge to show status from master branch only
@mwoss
Update Go version in go.mod to match minimum version required from docs
b4c2501
@CAEL0
Fix examples for RoundDown, RoundFloor, RoundUp, and RoundCeil (shops…
572d78e 
…pring#341)
@zlasd
Ensure empty Decimal returns correct zero-value NumDigits (shopspring…
1df8fb3 
…#301)
@zlasd
Fix mod when the divisor is slightly greater than the half of dividend (
7b4ffbc 
shopspring#312) (shopspring#317)
@falsaffa
Use Godoc standard to mark deprecated Equals and StringScaled methods(s…
142a0cf 
…hopspring#342)
@frankli0324
Fix overflow edge case in QuoRem method (shopspring#322)
b844c58
@cbelsole
Removed unnecessary min function for RescalePair method (shopspring#265)
b79c571 
Co-authored-by: Chris Belsole <chris.belsole@homelight.com>
@acln0
Add Compare method which forwards calls to Cmp (shopspring#346)
57a340d 
Given the interface definition

	type Ordered[T any] interface {
		Compare(T) int
	}

And the type constraint T Ordered[T], make decimal.Decimal satisfy this
constraint, so that generic code written against T Ordered[T] can work
with decimal values as smoothly as it works with time.Time values today.

Fixes: shopspring#345
@davseby
Add NewFromBigRat constructor (shopspring#288)
d00399e
@mwoss
Adjust Ln method to prevent infinity iteration loops (shopspring#357)
2b68c56 
* Adjust Ln method to prevent infinity iteration loops
* Add test case for infinity loop
@mwoss
Add improved implementation of power operation (shopspring#358)
78289cc 
* Adjust Pow implementation
* Add PowWithPrecision method
* Add PowInt32 method
* Add PowBigInt method
@serprex
Avoid reallocation of initial slice in MarshalBinary (GobEncode) (sho…
547861c 
…pspring#355)
@serprex
Optimize NumDigits method (shopspring#356)
bf7794e
@mwoss
Run CI on both push to origin branches and pull requests (shopspring#360
0e69d5c 
)
@mwoss
Drop support for Go versions older than 1.10 (shopspring#361)
ed8f76e 
* Drop support for Go versions older than 1.10
* Remove 1.18 from test suite
@serprex
Optimize BigInt (shopspring#359)
645a76e
@mwoss
Remove production usage from docs (shopspring#362)
2fa107d
@agmt
Add NewFromUint64 constructor (shopspring#352)
80ec940
@serprex
Support scanning uint64 (shopspring#364)
dd603cb
@mwoss
Add docs section with alternative libraries (shopspring#363)
275e48e
@mwoss
Release version 1.4.0 (shopspring#365)
a1bdfc3
@marcosvlehmkuhl @BogdanIrimie
String() trailing zeros as package configuration
78fabd7
@marcosvlehmkuhl @BogdanIrimie
change go.mod
2df4544
@krhubert @BogdanIrimie
add StringTrimZeros
0fb4648
@BogdanIrimie
Merge remote-tracking branch 'origin/master' into bogdan/pull-upstream
735862b
@BogdanIrimie BogdanIrimie self-assigned this May 17, 2024
@BogdanIrimie BogdanIrimie changed the title Bogdan/pull upstream Pull upstream to fix pow with decimals May 17, 2024
oanatmaria
oanatmaria reviewed May 19, 2024
View reviewed changes
go.mod Outdated
@@ -1,3 +1,3 @@
module github.com/ProlificLabs/decimal

go 1.13
go 1.10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we downgrade the go version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.10 was used in the upstream but I bumped it back to 1.13

@BogdanIrimie BogdanIrimie requested a review from oanatmaria July 4, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarondl0 aarondl0 Awaiting requested review from aarondl0

@dan-pulley dan-pulley Awaiting requested review from dan-pulley

@viovanov viovanov Awaiting requested review from viovanov

@marcosvlehmkuhl marcosvlehmkuhl Awaiting requested review from marcosvlehmkuhl

@bessiambre bessiambre Awaiting requested review from bessiambre

@ankojh ankojh Awaiting requested review from ankojh

@oanatmaria oanatmaria Awaiting requested review from oanatmaria

At least 1 approving review is required to merge this pull request.

Assignees

@BogdanIrimie BogdanIrimie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.