Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cipg: select only actively supported Emacs versions for Coq rc versions #733

Merged
merged 1 commit into from
Feb 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ci/tools/cipg.ml
Original file line number Diff line number Diff line change
Expand Up @@ -604,13 +604,15 @@ let select_newest first_emacs first_coq coqs emacses conts =
* version lists coqs and emacses are sorted with oldest version first,
* if there is an rc version, it's the last one
*)
let select_coq_rc_version coqs emacses conts =
let select_coq_rc_version first_emacs coqs emacses conts =
let first_emacs = get_version_index first_emacs emacses in
let newest_emacs = snd (list_last emacses) in
let (coq_v, coq_i) = list_last coqs in
if coq_v.release_candidate
then
List.iter
(fun (em_v, em_i) -> conts.(coq_i).(em_i) <- RC)
emacses
for em_i = first_emacs to newest_emacs do
conts.(coq_i).(em_i) <- RC
done
else
()

Expand All @@ -622,7 +624,7 @@ let select_containers first_full_range_coq first_active_emacs
select_lts_versions lts coqs emacses conts true;
select_all_latest_versions
first_full_range_coq first_active_emacs coqs emacses conts;
select_coq_rc_version coqs emacses conts;
select_coq_rc_version first_active_emacs coqs emacses conts;
()

(* Select version pairs to be tested in github CI and mark those as
Expand All @@ -634,7 +636,7 @@ let select_ci_pairs first_partial_range_coq first_active_emacs
select_newest first_active_emacs first_active_coq coqs emacses ci_pairs;
select_lts_versions lts coqs emacses ci_pairs false;
select_lts_latest_versions first_partial_range_coq lts coqs emacses ci_pairs;
select_coq_rc_version coqs emacses ci_pairs;
select_coq_rc_version first_active_emacs coqs emacses ci_pairs;
()


Expand Down
Loading