Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement leo execute #2491

Merged
merged 19 commits into from
Jul 20, 2023
Merged

[Feature] Implement leo execute #2491

merged 19 commits into from
Jul 20, 2023

Conversation

collinc97
Copy link
Collaborator

@collinc97 collinc97 commented Jul 19, 2023

Upgrades

  • snarkvm v0.14.5 updates
  • leo run significant speedup
  • leo execute command

@collinc97 collinc97 changed the title Feat/leo execute [Feature] Implement leo execute Jul 19, 2023
@collinc97 collinc97 requested a review from a team July 19, 2023 08:00
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2491 (8410b64) into testnet3 (59355c0) will increase coverage by 0.11%.
The diff coverage is 90.19%.

@@             Coverage Diff              @@
##           testnet3    #2491      +/-   ##
============================================
+ Coverage     78.90%   79.01%   +0.11%     
============================================
  Files           155      156       +1     
  Lines          4916     4947      +31     
  Branches       4915     4947      +32     
============================================
+ Hits           3879     3909      +30     
- Misses         1037     1038       +1     
Impacted Files Coverage Δ
compiler/compiler/tests/compile.rs 90.90% <ø> (-0.52%) ⬇️
errors/src/errors/package/package_errors.rs 0.00% <0.00%> (ø)
...ompiler/passes/src/flattening/flatten_statement.rs 65.43% <66.66%> (ø)
compiler/compiler/tests/utilities/mod.rs 89.18% <88.88%> (+1.31%) ⬆️
leo/package/src/root/env.rs 93.33% <93.33%> (ø)
compiler/compiler/tests/execute.rs 91.52% <100.00%> (-1.46%) ⬇️
...er/passes/src/code_generation/visit_expressions.rs 77.92% <100.00%> (ø)
.../src/static_single_assignment/rename_expression.rs 94.05% <100.00%> (ø)
leo/package/src/package.rs 80.64% <100.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to go!
Left a few minor nits that can be addressed at your discretion.

examples/README.md Outdated Show resolved Hide resolved
examples/basic_bank/build/build/main.avm Outdated Show resolved Hide resolved
examples/core/build/main.aleo Outdated Show resolved Hide resolved
leo/cli/commands/build.rs Show resolved Hide resolved
leo/cli/commands/new.rs Outdated Show resolved Hide resolved
leo/cli/commands/run.rs Outdated Show resolved Hide resolved
collinc97 and others added 3 commits July 19, 2023 16:03
Co-authored-by: d0cd <pranavsaig@gmail.com>
Signed-off-by: Collin Chin <16715212+collinc97@users.noreply.github.com>
@collinc97 collinc97 marked this pull request as ready for review July 19, 2023 23:20
@collinc97 collinc97 requested a review from d0cd July 19, 2023 23:20
Copy link
Collaborator

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me. leo run is now super-fast, thanks!
leo execute works too, and prints out a JSON structure.
Is there a switch to turn off the output of the JSON structure?

@collinc97 collinc97 merged commit d44457f into testnet3 Jul 20, 2023
8 checks passed
@collinc97 collinc97 deleted the feat/leo-execute branch July 20, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants