-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appending symbol table hashes to test expectations #2576
Conversation
Codecov Report
@@ Coverage Diff @@
## testnet3 #2576 +/- ##
============================================
- Coverage 80.09% 79.98% -0.12%
============================================
Files 159 160 +1
Lines 5321 5381 +60
Branches 5321 5381 +60
============================================
+ Hits 4262 4304 +42
- Misses 1059 1077 +18
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
Choices
ast/lib.rs
andcommon/symbol_table/mod.rs
. This made things more complicated and required adding a new file, so I decided to copy the relevant methods intocommon/symbol_table/mod.rs
instead.