feat: Use ensure_routine to streamline conversion from Qref to Bartiq #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstechly
approved these changes
Sep 30, 2024
mstechly
reviewed
Sep 30, 2024
| @@ -120,8 +121,8 @@ def filter_ports(self, directions: Iterable[str]) -> dict[str, Port[T]]: | |||
| return {port_name: port for port_name, port in self.ports.items() if port.direction in directions} | |||
|
|
|||
| @classmethod | |||
| def from_qref(cls, qref_obj: SchemaV1 | RoutineV1, backend: SymbolicBackend[T]) -> Routine[T]: | |||
| program = qref_obj.program if isinstance(qref_obj, SchemaV1) else qref_obj | |||
| def from_qref(cls, qref_obj: AnyQrefType, backend: SymbolicBackend[T]) -> Routine[T]: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the recently introduced
ensure_routinefromqref.functoolsto streamline conversions between Qref objects and Bartiq native dataclasses. Relies on PsiQ/qref#122 to be merged first (and then Qref to be released).Please verify that you have completed the following steps