refactor!: Convert local_variables from list of strings to dictionary#106
Merged
dexter2206 merged 3 commits intomainfrom Jul 9, 2024
Merged
refactor!: Convert local_variables from list of strings to dictionary#106dexter2206 merged 3 commits intomainfrom
dexter2206 merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As stated in PsiQ/bartiq#71, we want to change from representing
local_variablesfrom list of strings of the formvar=exprto a dictionary mapping variables to corresponding expressions. This PR introduces this change to Qref, so there is no discrepancy between Qref and Bartiq.Please verify that you have completed the following steps