update to version 0.2.3 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[`{scales}` 1.0.0](https://scales.r-lib.org/news/index.html#scales-100) is needed as that's when `number_bytes` was introduced.
I also renamed the internal function variables to make it easier to read.
These are now more specific than before.
Some of these tests had failed because when you don't supply a `ref_date` it will calculate the age today (using `Sys.Date()`), this meant that the 'people' are now older than when we first wrote the tests, so `age_from_chi` no longer returned the expected age. I wrote a small helper function to work out what the 'expected age' should be now, given the date we first set the tests.
`capture_warnings` has been superseded by `expect_warning` so I've swapped to using that.
This is faster and more readable than `!`
I have also made a few other tweaks to the code to make it a bit faster, and have added some new tests to account for the new parameter.
…_chi_tests Fix the tests covering `age_from_chi`
…n_year A large speed up to `extract_fin_year`
Remove the dependency on {gdata}
…-quiet-parameter #90 Add a `quiet` parameter to `format_postcode`
Automated re-knit of the README
Update installation instructions in the README
They will now throw an informative error, instead of the current behaviour where they will throw a warning but also return the expected result. The tests have also been updated such that they now expect these functions to error.
These links were valid but were redirecting - they have now been replaced.
Deprecate the renamed functions.
Moohan
requested changes
Sep 11, 2023
Co-authored-by: James McMahon <james.mcmahon@phs.scot>
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 99.25% 97.30% -1.95%
==========================================
Files 13 13
Lines 400 408 +8
==========================================
Hits 397 397
- Misses 3 11 +8
|
This is required because Windows will see .txt files as bigger due to the end of line characters.
Fix the file size test
Moohan
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.